IndexedDB: Make IndexeddbSerializer shareable between modules in matrix-sdk-indexeddb#4996
Merged
Hywan merged 6 commits intomatrix-org:mainfrom May 5, 2025
Merged
Conversation
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
…eddbCryptoStoreError Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
…eddbSerializerError Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Contributor
Author
|
Apologies about the failures, I am fixing them now! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4996 +/- ##
==========================================
+ Coverage 85.86% 85.88% +0.02%
==========================================
Files 325 325
Lines 35851 35851
==========================================
+ Hits 30783 30791 +8
+ Misses 5068 5060 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
Signed-off-by: Michael Goldenberg <m@mgoldenberg.net>
mgoldenberg
force-pushed
the
shared-indexeddb-serializer
branch
from
1104506 to
72da680
Compare
Hywan
approved these changes
May 5, 2025
Member
Hywan
left a comment
Hywan
left a comment
There was a problem hiding this comment.
Thanks for your patches. They are making sense to me. Thanks for doing small patches, I appreciate.
This was referenced May 23, 2025
1 task
1 task
This was referenced Jul 2, 2025
This was referenced Jul 15, 2025
Merged
This was referenced Aug 6, 2025
1 task
This was referenced Aug 25, 2025
This was referenced Sep 16, 2025
1 task
Merged
1 task
This was referenced Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This pull request has a high-level focus on integrating work on an IndexedDB implementation of the
EventCacheStore(see #4617). Those changes were rather large and sprawling and included code duplication, so this is part of a series of pull requests which will break that work into smaller, more manageable changes.Changes
This change is focused on de-duplicating code. In #4617,
crypto_store::indexeddb_serializerwas copy-and-pasted toevent_cache_store::indexeddb_serializerwith minor modifications (see here). In preparation for integrating this work, I have made the following changes.IndexeddbSerializerto the top-level so it may be shared between modules in the crate.IndexeddbSerializerErrorto be used withIndexeddbSerializer.IndexeddbCryptoStoreError, which was too specific for a generalized use-case.Additionally, I have prioritized making changes in such a way that does not change the public API of the crate. This means some of the changes weren't as sensible as they could have been, but it helped to keep the pull request small.
Future Work
The next pull request in this series will make additions to the
IndexeddbSerializer- there are two functions which #4617 added to its copy of the serializer and which are used byIndexeddbEventCacheStore.Signed-off-by: Michael Goldenberg m@mgoldenberg.net